Open Mitame opened 7 months ago
This is happening to me too, not even in test environment. 3.5.1. The promise just never resolves
If you have body-parser package just remove or comment it. Hope it will resolve
(reminder for me: try req.on('data') earlier)
are you testing formidable, or a project using formidable ?
If you have body-parser package just remove or comment it. Hope it will resolve
I tried commenting out busboy and busboy-body-parser and the parsing completed successfully.
If you have body-parser package just remove or comment it. Hope it will resolve
I had been banging my head against the wall for two days.... Thank you
@george-i @egargale yeah, that's a known thing that things don't work well if someone else is interacting with the body too.
Formidable can be simplified A LOT, but the problem to move directly the newest stuff is that people are relying on old versions, there's still people on v1.. I had the code ready for over a year, a dream of mine for v4-5, but yeah ;d
I encounter the same issue. Is there any solution available to resolve the problem?
I migrated an Express app using body-parser and formidable v1.2.6
to formidable v3.5.1
, and bumped into that issue. I was able to keep body-parser on, by calling await form.parse(req)
from a middleware running before body-parser. See commit https://github.com/inventaire/inventaire/commit/3b3c556. Hope that that can help others
Support plan
Context
18.18.2
next
v3.5.1
node-mocks-https
,form-data
Note this issue appears to only be present in tests as it is dependent on how promises get queued, but it could lead to a bug in live code.
What are you trying to achieve or the steps to reproduce?
A (somewhat) minimal reproducible test.
What was the result you got?
The test times out at 5000ms because the
await form.parse(req)
never resolves.What result did you expect?
The test passes.
Cause
The issue is caused as the callback handlers are set after an await of a promise.
https://github.com/node-formidable/formidable/blob/1699ec6fcb6fb01b2f7cacb735fea997358b00a5/src/Formidable.js#L232
This means the function returns, then data is sent which formidable is not listening for, then the
await
withinparse
is resolved and the handlers are set, but the events have already been missed, so the handlers just do nothing until Jest stops the test.Workaround
It's possible to call
req.send
in a promise with a slight delay, e.g.Breaking change
This is also a breaking change as it seems to have been introduced since
v3.2.4
. While the Promise style ofparse
didn't exist in that version, this bug also affects the callback style in the same manor.