search

node-gfx / node-canvas-prebuilt

Repo used to build binaries for node-canvas on CI
169 stars 31 forks source link

Add musl build based on alpine linux image #116

Open Logikgate opened 4 years ago

Logikgate commented 4 years ago

This is an attempt to add pre-built musl binaries, ref #77

For some reason this only works for nodejs v12 and higher. The binary builds without errors on lower versions but the final node -e "require('./node-canvas')" test results in a Segmentation Fault. I have tried trouble shooting it but can't seem to get anywhere. If you have any ideas why this would be I would appreciate a second set of 👀 .

In the meantime it seems adding node 12 and 13 musl binaries would still be of value so I'm opening this PR now for review, please let me know what you think.

Crazymax11 commented 4 years ago

what's about this pull request? Will it be merged?

smoke commented 4 years ago

closes https://github.com/node-gfx/node-canvas-prebuilt/issues/31 closes https://github.com/node-gfx/node-canvas-prebuilt/issues/77

chearon commented 4 years ago

We're wrapping up some work to do builds in the main repo using GitHub Actions, so once we get that completed we can move this PR to node-canvas. @Logikgate sounds good on https://github.com/node-gfx/node-canvas-prebuilt/pull/116#discussion_r395681433, sorry for the late reply.

ianvieira commented 4 years ago

@chearon Do you have any update about this PR? Seems like #1568 was already merged.

chearon commented 4 years ago

Sorry, we ran into issues: https://github.com/Automattic/node-canvas/issues/1622#issuecomment-667600108. If someone else wants to help over there and/or migrate this PR, I'll do my best to help get it merged. Native build stuff takes a lot of time so not sure when I'll be able to do it otherwise.

chrycheng commented 2 years ago

Automattic/node-canvas#1622 is closed already. What else is needed here for this PR to be accepted? I would be willing to help if I can.

coeing commented 2 years ago

Is this pull request still active? If yes, what is missing? If no, is there another pull request/issue that is? It would be really great to have a prebuilt package to speed up the builds of alpine docker containers which use node-canvas :)