search

node-gfx / node-canvas-prebuilt

Repo used to build binaries for node-canvas on CI
169 stars 31 forks source link

Automatically trigger and publish prebuilds #57

Closed zbjornson closed 3 years ago

zbjornson commented 5 years ago

A large number of new issues come from prebuilds not yet existing for recent canvas releases. Ideally we trigger prebuilds with a GitHub hook.

chearon commented 5 years ago

Both travis and appveyor let you specify env variables so it's possible when a new tag is pushed to node-canvas. I think I'd still have to make something to draft a new release here, since right now that's manual. @LinusU would still probably want to make sure the builds worked before npm publish since every now and then something goes wrong.

asturur commented 5 years ago

Also somehow pre-builds lack svg support. I removed my node-modules folder, pulled down 2.0.1, and run npm install. I can see from console i get the prebuilt package, but then when i run the local test server: image

and in my console:

👉  http://localhost:4000/
Error: node-canvas was built without SVG support
    at setSource (/Users/abogazzi/fabric/node-canvas/lib/image.js:102:14)
    at Image.set (/Users/abogazzi/fabric/node-canvas/lib/image.js:65:9)
    at Object.tests.drawImage(img) svg (/Users/abogazzi/fabric/node-canvas/test/public/tests.js:1893:11)
    at renderTest (/Users/abogazzi/fabric/node-canvas/test/server.js:21:16)
    at /Users/abogazzi/fabric/node-canvas/test/server.js:42:3
    at Layer.handle [as handle_request] (/Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/layer.js:95:5)
    at next (/Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/layer.js:95:5)
    at /Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/index.js:281:22
Error: node-canvas was built without SVG support
    at setSource (/Users/abogazzi/fabric/node-canvas/lib/image.js:102:14)
    at Image.set (/Users/abogazzi/fabric/node-canvas/lib/image.js:65:9)
    at Object.tests.drawImage(img) svg with scaling from drawImage (/Users/abogazzi/fabric/node-canvas/test/public/tests.js:1903:11)
    at renderTest (/Users/abogazzi/fabric/node-canvas/test/server.js:21:16)
    at /Users/abogazzi/fabric/node-canvas/test/server.js:42:3
    at Layer.handle [as handle_request] (/Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/layer.js:95:5)
    at next (/Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/layer.js:95:5)
    at /Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/index.js:281:22
Error: node-canvas was built without SVG support
    at setSource (/Users/abogazzi/fabric/node-canvas/lib/image.js:102:14)
    at Image.set (/Users/abogazzi/fabric/node-canvas/lib/image.js:65:9)
    at Object.tests.drawImage(img) svg with scaling from ctx (/Users/abogazzi/fabric/node-canvas/test/public/tests.js:1914:11)
    at renderTest (/Users/abogazzi/fabric/node-canvas/test/server.js:21:16)
    at /Users/abogazzi/fabric/node-canvas/test/server.js:42:3
    at Layer.handle [as handle_request] (/Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/layer.js:95:5)
    at next (/Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/layer.js:95:5)
    at /Users/abogazzi/fabric/node-canvas/node_modules/express/lib/router/index.js:281:22
zbjornson commented 5 years ago

@asturur wanna open a separate issue for that?