search

node-gfx / node-canvas-prebuilt

Repo used to build binaries for node-canvas on CI
170 stars 31 forks source link

Prebuilt for node_v72 #78

Closed BenoitClaveau closed 5 years ago

BenoitClaveau commented 5 years ago

Could you please create a prebuilt for window node_v72.

papandreou commented 5 years ago

@chearon, sorry to ping you, but do you know why those win32 prebuilts aren't in the 2.6.0 release? Looks like you managed to include them in 2.5.0, except for the node 12/v72 one?

Would be great to have a canvas release with prebuilts supporting both win32 and node 12 :sweat_smile:

I don't have access to a Windows machine, but do let me know if there's anything else I can do to help :)

chearon commented 5 years ago

@papandreou no worries at all, I needed the extra push. Binaries for 2.6.0/Windows/all node versions are up, as well as 2.5.0/Windows/Node 12!

2.5.0: was an issue with the wrong NAN version.

2.6.0: AppVeyor must have updated their images because it immediately built and pushed the new binaries when I started testing various fixes to MSYS2.

Sorry for the long wait everyone. At least I have some good ideas in case MSYS2 breaks like this again.

LinusU commented 5 years ago

@chearon awesome 👏 👏 tagging latest to 2.6.0 now 🚀