search

node-gh / gh-jira

NodeGH plugin for integrating Jira, an issue management system
34 stars 12 forks source link

Not allowing me to specify review request GitHub url #65

Closed protoEvangelion closed 6 years ago

protoEvangelion commented 6 years ago

When trying to transition the Jira issue to "Send for Review", it does not give me the option to specify the GitHub url of the PR. Same thing happens in the hook after the PR is sent with gh.

Is that the intended functionality?

I noticed in the config there is this transition object which looks like it would allow specifying the PR url: 

"transition": {
        "Code Review Request": {
            "Assignee": {
                "name": "{{options.assignee}}"
            },
            "Git Pull Request": "{{options.submittedLink}}"
        },
        "Create Review Request": {
            "Assignee": {
                "name": "{{options.assignee}}"
            },
            "Git Pull Request": "{{options.submittedLink}}"
        }
    }
henvic commented 6 years ago

I don't know. It's been a while since this was designed. Probably it just wasn't implemented. I am willing to accept a pull request with this feature.

protoEvangelion commented 6 years ago

@henvic Alrighty I will see what I can do!