node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.
http://nodegh.io
Other
1.71k stars 217 forks source link

feature request: add / remove collaborators #474

Open mateodelnorte opened 7 years ago

mateodelnorte commented 7 years ago

Hi there, I'd be happy to field a PR adding ability to add / remove collaborators to a repo: https://developer.github.com/v3/repos/collaborators/#add-user-as-a-collaborator

Can you give me some pointers on how to best get it implemented? Not sure if this is something that would be best done leveraging some existing code in repo.js or if going the route of copying milestone.js and tweaking it would be best.

Tips?

henvic commented 7 years ago

Hi @mateodelnorte,

First off, let me tell you we have been working on other unrelated things (WeDeploy) and this project has been left without much contributions for a while.

I recommend you see the https://github.com/node-gh/gh-jira to:

Once you have something I am more than open to merge your changes on the main repo, if you so desire. Or you can decide to contribute on a separate repo. Please choose whatever you find more appropriate for your program.

You can also take a look at https://github.com/node-gh/gh/tree/master/lib/cmds to see how commands were developed before ES6 came along (actually, I refactored gh-jira to use it; it used to be the worse package we had and now, after the refactoring, is my favorite).

One of the benefits of contributing back on the same repo is that you already have a test infrastructure and so on (though you may find it outdated and, please, feel free to update or improve it if you wish).

I would get gh-jira and tweak it and put it back on the main repo at lib/cmds. You would just have to see how to compile it for distribution (because we have to support old running environments).

If you need anything, want to talk about ideas, or ask questions, feel free to contact me here or directly.

Nowaker commented 7 years ago

@mateodelnorte You can use Terraform for this. https://www.terraform.io/docs/providers/github/index.html

mateodelnorte commented 7 years ago

People shouldn't have to install terraform to get this functionality

On Nov 2, 2017 8:56 AM, "Damian Nowak" notifications@github.com wrote:

@mateodelnorte https://github.com/mateodelnorte You can use Terraform for this. https://www.terraform.io/docs/providers/github/index.html

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/node-gh/gh/issues/474#issuecomment-341412337, or mute the thread https://github.com/notifications/unsubscribe-auth/AAh3XyIOh3rw6rl-E1pdpoaVNskB9scwks5sybvpgaJpZM4O17kd .