search

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.
http://nodegh.io
Other
1.71k stars 217 forks source link

Lock issue #480

Closed Nowaker closed 4 years ago

Nowaker commented 6 years ago

Something like gh is 123 --lock

protoEvangelion commented 6 years ago

@Nowaker Could you send a PR for this?

I am working on the backlog and it will be a while before I will be able to get to this.

Sounds like a cool feature :smile:

protoEvangelion commented 4 years ago

Looks like this can be done cleanly with the newly add octokit api: https://octokit.github.io/rest.js/#octokit-routes-issues-lock

File location to add this would be here: https://github.com/node-gh/gh/blob/8b772f11332260bf4d316a75957a0c6b2805d4db/src/cmds/issue.ts#L118

The approach would be to add a new flag like --lock.

And do if (options.lock)...

protoEvangelion commented 4 years ago

https://github.com/node-gh/gh/pull/687

protoEvangelion commented 4 years ago

@Nowaker can you give this a go or provide feedback if this meets your needs? https://github.com/node-gh/gh/pull/687

Nowaker commented 4 years ago

@protoEvangelion I guess it would had met my need two years ago for sure. That need is long gone with the project I was working on. But still thanks, someone else will find a use for it, yay! 😀

protoEvangelion commented 4 years ago

Ha sorry it took so long!

protoEvangelion commented 4 years ago

:tada: This PR is included in version 2.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: