Replace 'open' package with 'opn'

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.

http://nodegh.io

Other

1.71k stars 217 forks source link

Closed G07cha closed 6 years ago

G07cha commented 6 years ago

open is not maintained package which contains security vulnerability. I replaced it with opn which should be much more safer.

protoEvangelion commented 6 years ago

@G07cha Thanks for the PR much appreciated!

Does the terminal hang for you when opening something in the browser?

protoEvangelion commented 6 years ago

Added { wait: false } as an option and that fixes it 😉

Thanks again @G07cha !

G07cha commented 6 years ago

Good catch! Thanks, @protoEvangelion!