node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.
http://nodegh.io
Other
1.71k stars 217 forks source link

Write integration tests for `gh pr` cmd #566

Closed protoEvangelion closed 5 years ago

protoEvangelion commented 6 years ago

Currently there are only a few unit tests and no integration tests which reduces refactoring confidence.

A couple things on the roadmap are adding TypeScript and graphQL.

But before we do that, we need to have good integration tests starting with the pr cmd.

protoEvangelion commented 6 years ago

Ended up using the pattern adopted by Octokit/rest.js.

Since they already have the scenario of searching through issues we will use that as our starting point.

protoEvangelion commented 5 years ago

https://github.com/node-gh/gh/compare/master@%7B12-27-18%7D...master@%7B12-29-18%7D