search

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.
http://nodegh.io
Other
1.71k stars 217 forks source link

Output more descriptive error when user not found #567

Closed protoEvangelion closed 6 years ago

protoEvangelion commented 6 years ago

If you send a PR to a user that does not exist, the error is not very descriptive.

{ [Error: {"message":"Not Found","documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}]
...
code: 404

We should detect this error and output something like:

"The user you sent the PR to does not exist"

protoEvangelion commented 6 years ago

Thanks for the quick turnaround on this @juw910 I will test this soon. Great work!

protoEvangelion commented 6 years ago

:tada: This issue has been resolved in version 1.13.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: