search

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.
http://nodegh.io
Other
1.71k stars 217 forks source link

docs: adds badges for Prettier & Semantic Release to readme #572

Closed tijuthomas closed 6 years ago

jwu910 commented 6 years ago

Hi @tijuthomas,

Take a look at the https://github.com/node-gh/gh/blob/master/CONTRIBUTING.md for a guide on contributing to the project. The outline helps keep the commits consistent for all users. Cheers!

protoEvangelion commented 6 years ago

@tijuthomas could you update your commit message to include the proper format? We use the Angular guidelines so that Semantic Release can work properly. Here is some info about that if you want to learn more: https://egghead.io/lessons/javascript-automating-releases-with-semantic-release

In order to recommit you can do:

git reset --soft 9d2e72f
npm run commit
git push origin badges --force

That will walk you through an interactive commit process to make things easier.

tijuthomas commented 6 years ago

@protoEvangelion and @jwu910 thank you for the tips! I have updated the message and pushed it in. Does this work?

jwu910 commented 6 years ago

LGTM :dancer:

protoEvangelion commented 6 years ago

Merging thanks much @tijuthomas !

protoEvangelion commented 6 years ago

:tada: This PR is included in version 1.13.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: