It's difficult to see the branch breaks in `gh pr --detailed` view.

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.

http://nodegh.io

Other

1.71k stars 217 forks source link

It's difficult to see the branch breaks in `gh pr --detailed` view. #580

Closed drewbrokke closed 5 years ago

drewbrokke commented 6 years ago

When viewing PRs across multiple branches, the standard gh pr is not so bad:

But when calling gh pr --detailed, the visual noise is hard to parse through:

My 2 gripes are:

It's not obvious when a new pull begins besides the green number. Perhaps we could bold the title and/or introduce a line break after each pull summary?
The branch listings are too understated. Same suggestion as above :)

protoEvangelion commented 6 years ago

I agree! We cleaned up the formatting for listing issues and this could use a revamp too!

protoEvangelion commented 6 years ago

If someone wants to take a shot at this, you will want to start here: https://github.com/node-gh/gh/blob/master/lib/cmds/pull-request.js#L461

protoEvangelion commented 5 years ago

Related: #611, #595, #589

protoEvangelion commented 5 years ago

@drewbrokke here is what it looks like now:

Is that good enough for you?

drewbrokke commented 5 years ago

@protoEvangelion that looks really nice. Do you have an example of what it looks like when viewing pulls across multiple branches? That was my original gripe :)

protoEvangelion commented 5 years ago

It starts a new table with new headers so it is pretty clear visually

drewbrokke commented 5 years ago

PR send to https://github.com/node-gh/gh/pull/631

drewbrokke commented 5 years ago

Resent as https://github.com/node-gh/gh/pull/632

protoEvangelion commented 5 years ago

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: