search

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.
http://nodegh.io
Other
1.71k stars 217 forks source link

Add LGTM code quality badges #581

Closed xcorail closed 5 years ago

xcorail commented 5 years ago

Hi @protoEvangelion

It has been a pleasure to meet you at GitHubUniverse and discuss about LGTM.

I thought you might be interested in adding these LGTM code quality badges to this project, to show how you care about code quality and encourage contributors to do the same. To get an idea of the analyses reflected by these grades, check the alerts discovered by LGTM.

N.B.: I am on the team behind LGTM.com, I'd appreciate your feedback on this initiative, whether you're interested or not, if you find time to drop me a line. Thanks.

protoEvangelion commented 5 years ago

@jwu910 thoughts on including these two badges?

jwu910 commented 5 years ago

I don't think it hurts. You can review the types of alerts and see if its configurable to check against anything you need to specifically watch out for.

Edit: Looks like you're also already pulling alerts from https://snyk.io/test/github/node-gh/gh

protoEvangelion commented 5 years ago

@jwu910 Snyk is handling just security vulnerability checks.

@xcorail thanks for the follow up. You have a pretty amazing project.

I am happy to try it out 😄

protoEvangelion commented 5 years ago

@xcorail would you mind recommitting with chore(readme): Add LGTM.com code quality badges as the commit title for our semantic versioning to work correctly?

xcorail commented 5 years ago

Hi @protoEvangelion Done. Apologies for not following the contribution rules. Hope it's ok now.

protoEvangelion commented 5 years ago

@xcorail perfect thanks for changing that so quickly!

protoEvangelion commented 5 years ago

:tada: This PR is included in version 1.13.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: