node-gh home page shows 404 error in iframe - Githubissues

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.

http://nodegh.io

Other

1.71k stars 217 forks source link

node-gh home page shows 404 error in iframe #582

Closed ericnewton76 closed 5 years ago

ericnewton76 commented 5 years ago

btw, cool project! will npm install -g node-gh for sure.

just wanted to let you know...

jwu910 commented 5 years ago

Bump @protoEvangelion Looks like the Asciinema hosted GIF no is no longer available. Maybe re-record a gif.

https://github.com/node-gh/gh/blob/gh-pages/index.html#L54

protoEvangelion commented 5 years ago

@ericnewton76 thanks for the heads up!!! npm i -g gh by the way 😉

@jwu910 I think this has to do with the asciinema link. Wanna take a look on the gh-pages branch?

jwu910 commented 5 years ago

@protoEvangelion Already took a look. I think either asciinema deletes files after a certain time, or the original owner deleted the file. Probably will have to re-record something for it.

I used https://github.com/phw/peek on my own projects. Check it out =p

jwu910 commented 5 years ago

Nice job