feat(pull-request.ts): shows a different character for each possible pull request status

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.

http://nodegh.io

Other

1.71k stars 217 forks source link

Closed drewbrokke closed 5 years ago

protoEvangelion commented 5 years ago

Hmm it still prints out red x even though it is right now pending

protoEvangelion commented 5 years ago

drewbrokke commented 5 years ago

weird, works locally.

protoEvangelion commented 5 years ago

Maybe because we haven't updated the rest package fully yet which I think will return different data.

protoEvangelion commented 5 years ago

I ran this locally as well with this PR checked out.

drewbrokke commented 5 years ago

protoEvangelion commented 5 years ago

Silly me, forgot to build 🤦‍♂️

drewbrokke commented 5 years ago

Darn Typescript

protoEvangelion commented 5 years ago

Thanks again Drew! This should release once the tests pass on master.

drewbrokke commented 5 years ago

Sweet! 🎂

protoEvangelion commented 5 years ago

:tada: This PR is included in version 1.16.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: