search

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.
http://nodegh.io
Other
1.71k stars 217 forks source link

Re: Issue #624 (https://github.com/node-gh/gh/issues/624) #634

Closed keaglin closed 5 years ago

keaglin commented 5 years ago

gh re --new is working, tests passed. Current behavior: if a name is supplied, new remote repo will be given that name. If a name isn't supplied, it'll take the name of the pwd.

Also: I noted what Zev said about doing set-url but that seemed like a whole other thing (probably need child_process from node or a 3rd-party package).

protoEvangelion commented 5 years ago

@keaglin Great work and thanks for your patience on this! I will be more responsive & happily merge this.

Before merging this though we need a couple things. Can you take a look at https://github.com/node-gh/gh/blob/master/CONTRIBUTING.md#writing-code and then:

  1. resend this PR against the master branch
  2. move js from lib/cmds/repo.js to src/cmds/repo.ts (you can keep your js as is unless you get a ts compile error)
  3. move js from lib/helpers.js to src/utils.ts

Please let me know if you need help with any of these steps and sorry for the confusion 😄

keaglin commented 5 years ago

Thanks! And it's no problem.

I'll take a look at that and get everything fixed up.