deprecation warming for `github` module

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.

http://nodegh.io

Other

1.71k stars 217 forks source link

deprecation warming for `github` module #642

Closed rotty3000 closed 5 years ago

rotty3000 commented 5 years ago

~]$ sudo npm i -g gh
npm WARN deprecated github@0.2.4: 'github' has been renamed to '@octokit/rest' (https://git.io/vNB11)
/usr/bin/gh -> /usr/lib/node_modules/gh/bin/gh.js
+ gh@1.17.3
updated 1 package in 5.231s

protoEvangelion commented 5 years ago

Hey @rotty3000 thanks for the nudge. We are in the process of upgrading to octokit/rest however the upgrade was a bit more involved than anticipated because they use promises.

GH was written in the era of callbacks so it will require literally rewriting everything to promised based :)

Keep an eye on it here: https://github.com/node-gh/gh/issues/612