search

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.
http://nodegh.io
Other
1.71k stars 217 forks source link

(#645) Support sending PRs in draft state #654

Closed mdelapenya closed 4 years ago

protoEvangelion commented 5 years ago

@mdelapenya is this still a WIP or is it ready to go?

mdelapenya commented 5 years ago

It's ready to go in the sense that wanted to put in draft and discuss/review the changes. So please feel free to comment anything you see

protoEvangelion commented 5 years ago

Do you think it would be useful to print an console output that the PR was successfully opened in draft state?

protoEvangelion commented 4 years ago

Just started reviewing :)

protoEvangelion commented 4 years ago

Everything looks good except I'm wondering if it would be better to not have a shorthand for this flag.

So you would have to pass in --draft explicitly.

-F seems unclear to me. Any concerns with that?

mdelapenya commented 4 years ago

Agreed 👍

Thanks for the review!!

protoEvangelion commented 4 years ago

@mdelapenya are you participating in Hacktoberfest? If so you can close and resubmit this PR so you get credit 👍