Remove OOP style to prepare the way for FP - Githubissues

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.

http://nodegh.io

Other

1.71k stars 217 forks source link

Remove OOP style to prepare the way for FP #672

Closed protoEvangelion closed 5 years ago

protoEvangelion commented 5 years ago

Treat options as immutable with immer and remove prototype & this references.

lgtm-com[bot] commented 5 years ago

This pull request fixes 2 alerts when merging 8b772f11332260bf4d316a75957a0c6b2805d4db into 951cf0426126f4f51a6e708abdb6a934ce4257b4 - view on LGTM.com

fixed alerts:

2 for Unused variable, import, function or class

lgtm-com[bot] commented 5 years ago

This pull request fixes 7 alerts when merging 02d338fcfc0a115ca4c8160d32d1cdedc1a660dd into 951cf0426126f4f51a6e708abdb6a934ce4257b4 - view on LGTM.com

fixed alerts:

7 for Unused variable, import, function or class

lgtm-com[bot] commented 5 years ago

This pull request introduces 1 alert and fixes 7 when merging c1d0956039fcbae39d26bdd90bd5b72163f78f82 into 951cf0426126f4f51a6e708abdb6a934ce4257b4 - view on LGTM.com

new alerts:

1 for Unneeded defensive code

fixed alerts:

7 for Unused variable, import, function or class

lgtm-com[bot] commented 5 years ago

This pull request introduces 98 alerts and fixes 7 when merging 859d107c12c25a68eb7efe728744c349ab6b7aac into 951cf0426126f4f51a6e708abdb6a934ce4257b4 - view on LGTM.com

new alerts:

79 for Property access on null or undefined
14 for Unused variable, import, function or class
2 for Self assignment
2 for Assignment to constant
1 for Unneeded defensive code

fixed alerts:

7 for Unused variable, import, function or class

lgtm-com[bot] commented 5 years ago

This pull request introduces 89 alerts and fixes 7 when merging fed425793a05c1f22378a11021cad65cd32e39ad into 951cf0426126f4f51a6e708abdb6a934ce4257b4 - view on LGTM.com

new alerts:

74 for Property access on null or undefined
10 for Unused variable, import, function or class
2 for Self assignment
2 for Assignment to constant
1 for Unneeded defensive code

fixed alerts:

7 for Unused variable, import, function or class

lgtm-com[bot] commented 5 years ago

This pull request introduces 1 alert and fixes 7 when merging 423cf69553df84337e3862064d2a73708d2ccee8 into 1e6fe5dd70c594610c55d36a8a00badfacf3641b - view on LGTM.com

new alerts:

1 for Unneeded defensive code

fixed alerts:

7 for Unused variable, import, function or class

lgtm-com[bot] commented 5 years ago

This pull request introduces 1 alert and fixes 7 when merging 6024d1d3a1d3e1e8069f876ef22e2b6275f72116 into 1e6fe5dd70c594610c55d36a8a00badfacf3641b - view on LGTM.com

new alerts:

1 for Unneeded defensive code

fixed alerts:

7 for Unused variable, import, function or class

lgtm-com[bot] commented 5 years ago

This pull request introduces 1 alert and fixes 7 when merging 95d2f15ebe85f44c2b681945d489ce1f85850b2a into 1e6fe5dd70c594610c55d36a8a00badfacf3641b - view on LGTM.com

new alerts:

1 for Unneeded defensive code

fixed alerts:

7 for Unused variable, import, function or class

protoEvangelion commented 5 years ago

:tada: This PR is included in version 2.0.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket: