node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.
http://nodegh.io
Other
1.71k stars 217 forks source link

Add simple baseline performance benchmarking test #675

Closed protoEvangelion closed 4 years ago

protoEvangelion commented 4 years ago

Using something like https://github.com/logicalparadox/matcha add a simple test in the tests directory that will establish baseline performance for one command like gh is which lists issues. If we exceed the time it takes to run that cmd, the test should fail.

When we are testing, we use nock which serves a presaved github api response so we don't hit the network.

Therefore it should be safe to assume that we can expect a cmd to run within a threshold on travis ci.