search

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.
http://nodegh.io
Other
1.71k stars 217 forks source link

Update all contributors badge in readme to be 82 #676

Closed protoEvangelion closed 4 years ago

protoEvangelion commented 4 years ago

There is a badge in the top of the readme.md file that shows how many contributors have contributed to node-gh. We need to update that to 81 because we are missing 1 person + yourself because you are contributing :tada:

myluco commented 4 years ago

Who is the person?

protoEvangelion commented 4 years ago

The last person I tried to add with the all contributors bot, it didn't update the Readme badge automatically. I opened an issue on their repo: https://github.com/all-contributors/all-contributors-bot/issues/247

protoEvangelion commented 4 years ago

The person was added to the Readme but the badge wasn't updated.

ahonn commented 4 years ago

This problem seems to be because this line ends with (#contributors-)

image

all-contributors-bot is using all-contributors-cli v6.7.0. In all-contributors-cli v6.7.0, we can find these codes:

const badgeRegex = /\[!\[All Contributors\]\([a-zA-Z0-9\-./_:?=]+\)\]\(#\w+\)/

But this regular expression has been modified in this commit of v6.9.1

Badge can't be updated correctly because of this, using both cli and bot will cause this problem. Upgrading the cli version of all-contributors-bot dependencies should solve this problem.

protoEvangelion commented 4 years ago

Thanks for the thorough and quick report @ahonn!

I'll keep an eye on your open PR.

@myluco in the time being however, if you send a PR to update that number, I will be happy to merge it.

protoEvangelion commented 4 years ago

82 now

protoEvangelion commented 4 years ago

Closing because this will be handled automatically by https://github.com/all-contributors/all-contributors-bot/pull/250