search

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.
http://nodegh.io
Other
1.71k stars 217 forks source link

Success message #706

Closed Aaron-K-T-Berry closed 4 years ago

Aaron-K-T-Berry commented 4 years ago

This pr adds some nice ticks and crosses as you see for staus indicators on PRs.

These will show for failed and successful deletions of gists and repos. I also added the crosses to cancelling of the deletion process for gist and repos.

Closes #602

Aaron-K-T-Berry commented 4 years ago

I'm seeing failures on snapshot tests. What's the best way to update these snapshots?

protoEvangelion commented 4 years ago

Yup, you can run npm test -- -u or I usually have my tests running in watch mode npm run test:watch and then after the tests fail just hit the u key.

Aaron-K-T-Berry commented 4 years ago

Updated snapshots and merged master into branch. Should be ready to go 👍

protoEvangelion commented 4 years ago

Thanks @Aaron-K-T-Berry great work 👍

protoEvangelion commented 4 years ago

@all-contributors please add @Aaron-K-T-Berry for code

allcontributors[bot] commented 4 years ago

@protoEvangelion

I've put up a pull request to add @Aaron-K-T-Berry! :tada:

protoEvangelion commented 4 years ago

:tada: This PR is included in version 2.3.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: