fix: check for editor in environment variables

node-gh / gh

(DEPRECATED) GitHub CLI made with NodeJS. Use the official https://cli.github.com/ instead.

http://nodegh.io

Other

1.71k stars 217 forks source link

fix: check for editor in environment variables #748

Closed julien closed 4 years ago

julien commented 4 years ago

To determine which editor to use for commit messages look if $EDITOR or $VISUAL are set in the environment before checking the git config. If no editor is found throw an error. Fixes #745

protoEvangelion commented 4 years ago

Just started reviewing :)

protoEvangelion commented 4 years ago

Hmm it's passing locally but not on CI. I'm looking into it now.

protoEvangelion commented 4 years ago

:tada: This PR is included in version 2.8.3 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: