node-gradle / gradle-node-plugin

Gradle plugin for integrating NodeJS in your build. :rocket:
Apache License 2.0
603 stars 118 forks source link

Improve Mac M1 support #214

Open deepy opened 2 years ago

deepy commented 2 years ago

Extracting #204

But instead of using uname on M1 macs we should be using sysctl sysctl.proc_translated

Vampire commented 2 years ago

Should this be closed? The changelog claims this is fixed for 3.2.1

deepy commented 2 years ago

The current solution in 3.2.1 is using uname which as far as I can tell should always be correct (but according to testimonies in #204 that's not true)

My new work laptop is a M1 mac and as soon as I get that I'll switch to sysctl sysctl.proc_translated

deepy commented 1 year ago

After fixing https://github.com/node-gradle/gradle-node-plugin/issues/234 an option could be added to automatically run older node versions through Rosetta