node-gradle / gradle-node-plugin

Gradle plugin for integrating NodeJS in your build. :rocket:
Apache License 2.0
601 stars 117 forks source link

Added support for pnpm #240

Closed DreierF closed 2 years ago

DreierF commented 2 years ago

Based on https://github.com/node-gradle/gradle-node-plugin/pull/89 by @langrp Fixes #67

The tests for MacOS and Windows are passing, but for some reason the tests on Ubuntu seem to hang without producing any error in the end.

Any idea what could go wrong there?

deepy commented 2 years ago

They could also genuinely be timing out, the big suite takes a lot of time

deepy commented 2 years ago

I'm going to regret merging this since the pnpm tests are the 3 slowest test classes 🥲 I'll have to rework the tests and/or the test setup before I can make a release

FortinFred commented 1 year ago

Please consider updating documentation.

It's unclear if a pnpm_install task is now available.

deepy commented 1 year ago

@FortinFred there's a pnpmInstall to match, best bet currently is to look at the pnpm integtests Opening an issue for this would be best though as closed issues/PRs easily disappear in notifications