NpmTask workingDir should be DirectoryProperty

node-gradle / gradle-node-plugin

Gradle plugin for integrating NodeJS in your build. :rocket:

Apache License 2.0

599 stars 117 forks source link

NpmTask workingDir should be DirectoryProperty #305

Open wakingrufus opened 5 months ago

wakingrufus commented 5 months ago

NpmTask's workingDir property is currently a RegularFileProperty but it probably should be a DirectoryProperty similar to how NodeTask's workingDir property is.

I can implement this, if you wish, but I am not sure how you would want to handle breaking compatibility with existing code.

deepy commented 5 months ago

Next version is going to be a major so feel free to send a PR :-) And no tests breaks with the change either, so this was potentially just an oversight when we moved to providers and properties 4 years ago