search

node-inspector / v8-profiler

node bindings for the v8 profiler
BSD 2-Clause "Simplified" License
1.13k stars 134 forks source link

Does not build under Node v6.0.0 #89

Closed RobertWHurst closed 8 years ago

RobertWHurst commented 8 years ago
screen shot 2016-04-26 at 7 45 39 pm

Just updated to Node v6.0.0. It seems I can no longer install node-inspector because v8-profiler is failing to build against the new V8.

njbraun commented 8 years ago

+1

evanlucas commented 8 years ago

This should be fixable by bumping to the latest nan version.

RobertWHurst commented 8 years ago

Should be fixed now that my PR has been merged :)

RobertWHurst commented 8 years ago

@3y3 Can you do a release to NPM?

3y3 commented 8 years ago

In progress

RobertWHurst commented 8 years ago

@3y3 🍻

RobertWHurst commented 8 years ago

@3y3 I've got a PR for node-inspector so let me know once you've published 😄

3y3 commented 8 years ago

I should also update v8-debug deps v8-profiler will be published after this build https://ci.appveyor.com/project/3y3/v8-profiler

RobertWHurst commented 8 years ago

@3y3 Okie dokie.

3y3 commented 8 years ago

@RobertWHurst ,v8-profiler 5.6.1 was published. Thank you for fast fix!

(v8-debug is next in line)