search

node-inspector / v8-profiler

node bindings for the v8 profiler
BSD 2-Clause "Simplified" License
1.13k stars 134 forks source link

Error when `npm rebuild` with node v7 #99

Open shaunxu opened 8 years ago

shaunxu commented 8 years ago

Upgrade to node v7 and execute npm rebuild in my project, then got error message said 

Error: v8-profiler@5.6.5 install: `node-pre-gyp install --fallback-to-build`

Two errors reported

../src/heap_snapshot.cc:46:46: error: no member named 'GetHiddenValue' in 'v8::Object'
      info.GetReturnValue().Set(info.This()->GetHiddenValue(__root));
                                ~~~~~~~~~~~  ^
../src/heap_snapshot.cc:50:20: error: no member named 'SetHiddenValue' in 'v8::Object'
      info.This()->SetHiddenValue(__root, _root);
      ~~~~~~~~~~~  ^
2 errors generated.
bonesoul commented 7 years ago

same here

pmurias commented 7 years ago

PR https://github.com/node-inspector/v8-profiler/pull/96 solves the issue.

helio-frota commented 7 years ago

Hi folks, Any updates ?

We have a good tool that generates flamegraph and do some profiling things, and that tool is using v8-profiler, and we can't test against Node.js 7x yet :/

thanks.

megastef commented 7 years ago

Is this published to NPM? I've got the same problem on node 7.3.0

bonesoul commented 7 years ago

Same with 7.4.0 too.

bompus commented 7 years ago

Just checking in to see if this package is going to be updated for node v7+ or taken over by somebody else?

pkoretic commented 7 years ago

I'm also interested why has it stopped and what the future holds @3y3 @bajtos ?

helio-frota commented 7 years ago

I'm using this for now: https://github.com/node-inspector/v8-profiler/pull/96#issuecomment-271152662

hustxiaoc commented 7 years ago

Please try v8-profiler@5.7.0 , should work now!