node-js-libs / curlrequest

A cURL wrapper
MIT License
184 stars 44 forks source link

replace escape with encodeURIComponent for POST data #7

Closed sanderpick closed 11 years ago

sanderpick commented 11 years ago

In your POST data parsing you're using escape(), which was causing failure for some special characters, including foreign alphabet letters. Using encodeURIComponent instead solves the problem.

http://stackoverflow.com/questions/75980/best-practice-escape-or-encodeuri-encodeuricomponent

Thanks for the great module!

chriso commented 11 years ago

Great, thanks