Closed nabeelbukhari closed 1 year ago
@fengmk2 Can you please help review this PR?
Merging #113 (ee82816) into master (2092714) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #113 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 223 224 +1
Branches 43 43
=========================================
+ Hits 223 224 +1
Files Changed | Coverage Δ | |
---|---|---|
lib/agent.js | 100.00% <100.00%> (ø) |
|
lib/https_agent.js | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
4.4.0
@nabeelbukhari Thanks!
As per http.agent createConnection method, the method should return a socket but I found that current implemenation of createConnection for Agent doesn't return socket.
Checklist
npm test
passesAffected core subsystem(s)
N/A
Description of change
Return socket from createConnection and add type for createConnection