search

node-modules / agentkeepalive

Support keepalive http agent.
MIT License
579 stars 57 forks source link

agent.isDestroyed undefined for node 0.12.0 on agentkeepalive@2.x #14

Closed matthewmueller closed 5 years ago

matthewmueller commented 9 years ago

Looks like it's defined in _http_agent.js but not agent.js.

fengmk2 commented 9 years ago

I need to take a look of changes between 0.11.x and 0.12.0

codereflection commented 9 years ago

+1 also running into this issue. Was this due to something changing in node?

abarre commented 9 years ago

Does it mean that this agent is not ready for node 0.12.0 ?

kevinhikaruevans commented 9 years ago

Doesn't seem to work on v0.12.x, but works just fine on v0.10.40. Hmmm... maybe it's because I didn't update the package to the latest on my 0.10.40 server

Also, I just changed my agentkeepalive version from "^0.2.2" to ""0.2.2" and it seemed to work fine on both versions.

vvo commented 9 years ago

Does it mean that this agent is not ready for node 0.12.0 ?

@abarre Why not use builtin keepalive agent in node 0.12? Works well

abarre commented 9 years ago

@vvo, yes, I see it after posting this comment :)