Auto https. - Githubissues

node-modules / agentkeepalive

Support keepalive http agent.

MIT License

579 stars 57 forks source link

Auto https. #38

Closed DylanPiercey closed 8 years ago

DylanPiercey commented 8 years ago

It would be nice if one keep alive agent could automatically switch between http and https requests. I believe it use to work this way but then the api's were separated.

fengmk2 commented 8 years ago

agentkeepalive API just keep as same as orignal http.Agent, including the usage.

DylanPiercey commented 8 years ago

I believe the default http.Agent (in this module) used to work with https as well, is this wrong?

If this is not possible thats fine, it would just be convenient to be able to share the same agent across http(s) requests.

fengmk2 commented 8 years ago

http request use http.Agent
https request use https.Agent https://nodejs.org/api/https.html#https_class_https_agent

It's hard to detect the going request is http or https.

DylanPiercey commented 8 years ago

Alright thanks for pointing this out!