search

node-modules / agentkeepalive

Support keepalive http agent.
MIT License
579 stars 57 forks source link

WIP: fix: always honor user passed timeout option #41

Closed ibigbug closed 5 years ago

ibigbug commented 8 years ago

closed https://github.com/node-modules/urllib/issues/206

codecov-io commented 8 years ago

Current coverage is 95.78% (diff: 66.66%)

Merging #41 into master will decrease coverage by 0.32%

@@             master        #41   diff @@
==========================================
  Files             5          5          
  Lines           283        285     +2   
  Methods          25         25          
  Messages          0          0          
  Branches         59         60     +1   
==========================================
+ Hits            272        273     +1   
- Misses           11         12     +1   
  Partials          0          0

Powered by Codecov. Last update 2a913cc...3fff272

fengmk2 commented 5 years ago

通过 node 10 的源代码，agent.options.timeout 是在 createConnection 的时候设置的。