search

node-modules / agentkeepalive

Support keepalive http agent.
MIT License
579 stars 57 forks source link

feat: impl the new Agent extend http.Agent #69

Closed fengmk2 closed 5 years ago

fengmk2 commented 5 years ago

This is a BREAKING change.

Don't use patch mode anymore. Improve code coverage to 100%.

codecov[bot] commented 5 years ago

Codecov Report

Merging #69 into master will increase coverage by 8.48%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #69      +/-   ##
========================================
+ Coverage   91.51%   100%   +8.48%     
========================================
  Files           4      4              
  Lines         283    176     -107     
========================================
- Hits          259    176      -83     
+ Misses         24      0      -24
Impacted Files Coverage Δ
lib/constants.js 100% <100%> (ø)
lib/agent.js 100% <100%> (+5%) :arrow_up:
lib/https_agent.js 100% <100%> (ø) :arrow_up:
index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b81362...4089edd. Read the comment docs.

fengmk2 commented 5 years ago

I will merge today and use on npm.taobao.org for a week stable tests.

fengmk2 commented 5 years ago

竟然合并了才看的评论，我再提交一下。

fengmk2 commented 5 years ago

4.0.0

dead-horse commented 5 years ago

白天评论发不出来..

skeggse commented 4 years ago

What is the breaking change introduced in this PR?