search

node-modules / agentkeepalive

Support keepalive http agent.
MIT License
579 stars 57 forks source link

fix: HttpsAgent Type Definition #72

Closed AndrewLeedham closed 5 years ago

AndrewLeedham commented 5 years ago

fixes: #71

codecov[bot] commented 5 years ago

Codecov Report

Merging #72 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #72   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         174    174           
=====================================
  Hits          174    174

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9124343...9ca6ad2. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #72 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #72   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         174    174           
=====================================
  Hits          174    174

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9124343...9ca6ad2. Read the comment docs.

AndrewLeedham commented 5 years ago

@fengmk2 Thanks for merging this, would it be possible to include this in a release on npm. I.e. 4.0.1?

fengmk2 commented 5 years ago

4.0.1 Released now! @AndrewLeedham sorry for the delay.

AndrewLeedham commented 5 years ago

Hmm @fengmk2, seeing a new error now: image seems like #70 and #72 weren't compatible changes together.

See: #73 #74