node-modules / agentkeepalive

Support keepalive http agent.

MIT License

579 stars 57 forks source link

Types are out of sync with current implementation #80

Closed topicus closed 4 years ago

topicus commented 5 years ago

createSocket is no longer in the base code and was apparently replaced by createConnection so I have updated the types to reflect this change.

codecov[bot] commented 5 years ago

Codecov Report

Merging #80 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #80   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         174    174           
=====================================
  Hits          174    174

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48e01a4...d1abed2. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #80 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #80   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         174    174           
=====================================
  Hits          174    174

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48e01a4...fad0937. Read the comment docs.

fengmk2 commented 4 years ago

https://github.com/node-modules/agentkeepalive/pull/87