search

node-modules / agentkeepalive

Support keepalive http agent.
MIT License
579 stars 57 forks source link

Support for Node 10 APIs #83

Closed AxelTerizaki closed 4 years ago

AxelTerizaki commented 4 years ago

Judging from this comment on got's v10 beta ( sindresorhus/got#876 ), agentkeepalive does not use Node 10's APIs.

Could it be possible to add that support so we can upgrade to got v10 on our app ?

Thanks in advance.

kennethaasan commented 4 years ago

Not sure if this is a problem with agentkeepalive. I eventually found out that my issue in https://github.com/sindresorhus/got/issues/876#issuecomment-558622058 is related to using New Relic (https://github.com/newrelic/node-newrelic)

AxelTerizaki commented 4 years ago

Oh, I'll have to test it out then, and see what happens, I guess. I'll try to test it this weekend, and if it still works after upgrading to Got 10 then I'll close this issue.

Thanks for the feedback.

kennethaasan commented 4 years ago

https://github.com/newrelic/node-newrelic/issues/316

AxelTerizaki commented 4 years ago

Seems to work well, so I'm closing it. Sorry for opening it in the first place :)