search

node-modules / compressing

Everything you need for compressing and uncompressing
MIT License
431 stars 36 forks source link

fix: handle error from yazl when file not exist #19

Closed DiamondYuan closed 5 years ago

DiamondYuan commented 5 years ago

fixes #18

DiamondYuan commented 5 years ago

yazl 在文件不存在的时候 emit 了一个错误

https://github.com/thejoshwolfe/yazl/blob/cfab32fc430c752971fb5c83ee5c60f2f11bc5ad/index.js#L30

原来的代码没有处理错误。

codecov[bot] commented 5 years ago

Codecov Report

Merging #19 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #19      +/-   ##
=========================================
+ Coverage   98.09%   98.1%   +<.01%     
=========================================
  Files          19      19              
  Lines         526     527       +1     
=========================================
+ Hits          516     517       +1     
  Misses         10      10
Impacted Files Coverage Δ
lib/zip/file_stream.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07eaf90...ec6c900. Read the comment docs.

fengmk2 commented 5 years ago

1.3.2 released

@DiamondYuan Thanks!