node-modules / compressing

Everything you need for compressing and uncompressing

MIT License

437 stars 34 forks source link

feat: support uncompressing symlink #31

Closed atian25 closed 1 year ago

atian25 commented 5 years ago

closes https://github.com/node-modules/compressing/pull/58 https://github.com/node-modules/compressing/issues/93

fengmk2 commented 5 years ago

@atian25 ci 没过。

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7d605fe). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage          ?   39.77%           
=========================================
  Files             ?       19           
  Lines             ?      533           
  Branches          ?        0           
=========================================
  Hits              ?      212           
  Misses            ?      321           
  Partials          ?        0

Impacted Files	Coverage Δ
lib/utils.js	`58.4% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d605fe...e9b5b7b. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #31 (72dbca9) into master (d17b1ed) will increase coverage by 11.91%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #31       +/-   ##
===========================================
+ Coverage   85.82%   97.74%   +11.91%     
===========================================
  Files          19       19               
  Lines        1009     1018        +9     
  Branches      221      271       +50     
===========================================
+ Hits          866      995      +129     
+ Misses        143       23      -120

Files Changed	Coverage Δ
lib/utils.js	`98.10% <100.00%> (+31.27%)`	:arrow_up:

... and 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

fengmk2 commented 5 years ago

@atian25 ci 修一下？

atian25 commented 5 years ago

ci 文件权限那个有点奇怪，本地没问题，ci 的权限不一样

fengmk2 commented 1 year ago

我晚点 rebase 一下继续推进。

ayushmanchhabra commented 1 year ago

@fengmk2 @atian25 I am interested in getting this merged. The module is used in nw-builder. Currently, it is not recognising symbolic links on decompression. This would help a ton!

fengmk2 commented 1 year ago

@ayushmanchhabra Sure, I will merge it in this week.

zkrige commented 1 year ago

While this looks like it should work, its still not processing symlinks properly on extract