node-modules / compressing

Everything you need for compressing and uncompressing
MIT License
431 stars 36 forks source link

fix: should resolve when all fileWriteStream finished #7

Closed popomore closed 7 years ago

mention-bot commented 7 years ago

@popomore, thanks for your PR! By analyzing the history of the files in this pull request, we identified @shaoshuai0102 to be a potential reviewer.

codecov[bot] commented 7 years ago

Codecov Report

Merging #7 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   97.95%   97.99%   +0.04%     
==========================================
  Files          18       18              
  Lines         489      499      +10     
==========================================
+ Hits          479      489      +10     
  Misses         10       10
Impacted Files Coverage Δ
lib/utils.js 96.73% <100%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79086bc...ba816c0. Read the comment docs.

popomore commented 7 years ago

@atian25 egg-init 有这个问题

shaoshuai0102 commented 7 years ago

+1 这个也挺难看出来的

shaoshuai0102 commented 7 years ago

+ compressing@1.2.3

atian25 commented 7 years ago

😓