search

node-modules / mm

An simple but flexible mock(or say stub) package, mock mate
Other
158 stars 16 forks source link

use stream class to replace EventEmitter. #35

Closed iyuq closed 6 years ago

iyuq commented 7 years ago

request and response are stream, use stream to simulate request and response seems more reasonable. It can simplify the writing of code and improve the readability of code as well.

mention-bot commented 7 years ago

@iyuq, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @popomore and @dead-horse to be potential reviewers.

codecov[bot] commented 7 years ago

Codecov Report

Merging #35 into master will decrease coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   97.79%   97.75%   -0.05%     
==========================================
  Files           3        3              
  Lines         272      267       -5     
==========================================
- Hits          266      261       -5     
  Misses          6        6
Impacted Files Coverage Δ
lib/mm.js 97.43% <100%> (-0.06%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0aacd61...d809263. Read the comment docs.

fengmk2 commented 6 years ago

I will rebase from master before merge.

fengmk2 commented 6 years ago

landed 72e54784c5c0c094da6c345ce65f50bbc31b5889

fengmk2 commented 6 years ago

@iyuq Thanks!

fengmk2 commented 6 years ago

2.2.0