search

node-modules / urllib

Request HTTP(s) URLs in a complex world.
MIT License
729 stars 118 forks source link

Remove utility to reduce package size #362

Closed jimmywarting closed 2 years ago

jimmywarting commented 3 years ago

This two can easily be replaced with Object.assign({}, ...) or with spread { ... } https://github.com/node-modules/urllib/blob/f2a42d19d2236979c16eea13c229839e5a78b381/lib/httpclient.js#L40 https://github.com/node-modules/urllib/blob/f2a42d19d2236979c16eea13c229839e5a78b381/lib/httpclient.js#L51

Here you can use Object.keys() https://github.com/node-modules/urllib/blob/04734a13e146da501f4e38333d5de9f9bbb259d1/lib/urllib.js#L309

fengmk2 commented 2 years ago

Pull request is welcome

TommyDew42 commented 2 years ago

Hi! Can I take this up?

atian25 commented 2 years ago

sure