search

node-modules / urllib

Request HTTP(s) URLs in a complex world.
MIT License
727 stars 117 forks source link

The version number needs to be modified, and the old node is no longer available #376

Closed starmooms closed 2 years ago

starmooms commented 2 years ago

Installation failed on node@8.9.3 

yarn add urllib

yarn add v1.21.1
info No lockfile found.
[1/4] Resolving packages...
info There appears to be trouble with your network connection. Retrying...
[2/4] Fetching packages...
error socks@2.6.1: The engine "node" is incompatible with this module. Expected version ">= 10.13.0". Got "8.9.3"
error Found incompatible module.

This may be because

fix: upgrade proxy-agent to fix the security vulnerability

Cause breakthrough change

Our old project use ali-oss@^4.6.3 on node@8.9.3, dependencies urllib@^2.17.1

Due to the wrong version number, it cannot be used when updating as a module

yarn add ali-oss@^4.6.3

yarn add v1.21.1
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
error socks@2.6.1: The engine "node" is incompatible with this module. Expected version ">= 10.13.0". Got "8.9.3"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

## can ignore the engine to view the 'yarn.lock' dependency
# yarn add ali-oss@^4.6.3 --ignore-engines

Therefore, you may need to republish it twice. The repaired 2.*.* can be used, and the new 3.*.* can be published

fengmk2 commented 2 years ago

cc @hyj1991

fengmk2 commented 2 years ago

@starmooms node v8 is no more LTS support, can you upgrade node to 10 or 12?

hyj1991 commented 2 years ago

Hello starmooms, thanks for your feedback.

Actually urllib no longer support non-lts version, please upgrade your nodejs :)

starmooms commented 2 years ago

We rely on ali-oss@^4.6.3 in a public module. The upgrade may involve other projects and can only be used for the time being ali-oss@4.4.3.

I think as a basic dependency, there should be good version number management, which may involve many other projects. But the version number may have been confused for a long time (#316)

Anyway, thank you for you reply. This in can be closed

fengmk2 commented 2 years ago

https://github.com/TooTallNate/node-proxy-agent/blob/master/package.json#L10 proxy-agent support node@8