node-modules / urllib

Request HTTP(s) URLs in a complex world.
MIT License
726 stars 117 forks source link

📦 NEW: [BREAKING] Refactor impl base on undici #382

Closed fengmk2 closed 2 years ago

fengmk2 commented 2 years ago

closes https://github.com/eggjs/egg/issues/4847

Base on undici request API https://github.com/nodejs/undici

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging eecb50a36bbc8c46dbc82f20cbe9c95b05b8c31e into 518d22c30e3888e6cffec0572f05af0fc30f824f - view on LGTM.com

new alerts:

codecov[bot] commented 2 years ago

Codecov Report

Merging #382 (20944ee) into master (ec200b0) will increase coverage by 5.84%. The diff coverage is 99.09%.

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   93.24%   99.09%   +5.84%     
==========================================
  Files           6        4       -2     
  Lines         829      331     -498     
  Branches      225      114     -111     
==========================================
- Hits          773      328     -445     
+ Misses         56        3      -53     
Impacted Files Coverage Δ
src/HttpClient.ts 98.87% <98.87%> (ø)
src/HttpAgent.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/utils.ts 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging f7b4932ac2434a3af4bbe30f224affa55b37f6f2 into 518d22c30e3888e6cffec0572f05af0fc30f824f - view on LGTM.com

new alerts:

fengmk2 commented 2 years ago

@atian25 没看到效果?

atian25 commented 2 years ago

@atian25 没看到效果?

ts-jest 那个源码有点绕,不知道是不是 ts-jest 的 preset 和 reporters 冲突了。

也有可能是 GitHub Action 问题,可以等下个 PR 再看看。

socket-security[bot] commented 2 years ago

Socket Security Report

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
core-js-pure@3.23.4 (added) postinstall package.json via eslint-config-egg@12.0.0, eslint-plugin-jsx-a11y@6.6.0, aria-query@4.2.2, @babel/runtime-corejs3@7.18.6
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 1 new install script detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules

Powered by socket.dev

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 860c650f18e64a95503ab72b2968f8c8088ed270 into 518d22c30e3888e6cffec0572f05af0fc30f824f - view on LGTM.com

new alerts:

fengmk2 commented 2 years ago

3.0.0