search

node-modules / urllib

Request HTTP(s) URLs in a complex world.
MIT License
726 stars 117 forks source link

fix: parsing multiple www-authenticate response headers #421

Closed ghost closed 1 year ago

ghost commented 1 year ago

fix for issue 420 (nice) https://github.com/node-modules/urllib/issues/420 Apparently it's a @types/node issue as well.

fengmk2 commented 1 year ago

Can you add a test case for this change?

ghost commented 1 year ago

An example of a service that provides multiple challenges split into different headers: https://caldav.icloud.com

codecov[bot] commented 1 year ago

Codecov Report

Merging #421 (8b73b75) into master (5c0b4e9) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files           6        6           
  Lines         978      981    +3     
  Branches      226      228    +2     
=======================================
+ Hits          972      975    +3     
  Misses          6        6
Impacted Files Coverage Δ
src/HttpClient.ts 99.50% <100.00%> (+<0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

fengmk2 commented 1 year ago

3.5.1