node-modules / urllib

Request HTTP(s) URLs in a complex world.
MIT License
726 stars 117 forks source link

👌 IMPROVE: Keep more compatible d.ts on urllib v2 #425

Closed fengmk2 closed 1 year ago

fengmk2 commented 1 year ago

支持 ts 之后,api 参数的兼容性太高难度。

codecov[bot] commented 1 year ago

Codecov Report

Merging #425 (f188ecd) into master (6278f57) will decrease coverage by 0.18%. The diff coverage is 89.65%.

:exclamation: Current head f188ecd differs from pull request most recent head 4070f4f. Consider uploading reports for the commit 4070f4f to get more accurate results

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
- Coverage   99.40%   99.21%   -0.19%     
==========================================
  Files           6        7       +1     
  Lines        1002     1153     +151     
  Branches      237      239       +2     
==========================================
+ Hits          996     1144     +148     
- Misses          6        9       +3     
Impacted Files Coverage Δ
src/index.ts 92.50% <80.00%> (-7.50%) :arrow_down:
src/HttpClient.ts 99.51% <100.00%> (+<0.01%) :arrow_up:
src/Request.ts 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

fengmk2 commented 1 year ago

3.8.0