search

node-modules / urllib

Request HTTP(s) URLs in a complex world.
MIT License
725 stars 115 forks source link

fix: fix undefined search params of get method #436

Closed linrf closed 1 year ago

linrf commented 1 year ago

fix this image

codecov[bot] commented 1 year ago

Codecov Report

Merging #436 (6df18eb) into master (bda2231) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files           8        8           
  Lines        1222     1224    +2     
  Branches      233      233           
=======================================
+ Hits         1218     1220    +2     
  Misses          4        4
Impacted Files Coverage Δ
src/HttpClient.ts 99.83% <100.00%> (+<0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

fengmk2 commented 1 year ago

还是保持 URL SearchParams 的逻辑

fengmk2 commented 1 year ago

https://github.com/node-modules/urllib/pull/441