node-modules / urllib

Request HTTP(s) URLs in a complex world.
MIT License
725 stars 114 forks source link

feat: print more socket info on UND_ERR_CONNECT_TIMEOUT error #477

Closed fengmk2 closed 7 months ago

fengmk2 commented 7 months ago
HttpClientConnectTimeoutError: Connect Timeout Error
    at #requestInternal (/Users/fengmk2/git/github.com/node-modules/urllib3/dist/commonjs/HttpClient.js:586:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async HttpClient.request (/Users/fengmk2/git/github.com/node-modules/urllib3/dist/commonjs/HttpClient.js:111:16)
    at async request (/Users/fengmk2/git/github.com/node-modules/urllib3/examples/timing.cjs:17:15) {
  status: -1,
  headers: {},
  socket: {
    id: 1,
    localAddress: '',
    localPort: 0,
    remoteAddress: '',
    remotePort: 0,
    remoteFamily: '',
    bytesWritten: 0,
    bytesRead: 0,
    handledRequests: 0,
    handledResponses: 0,
    connectErrorTime: 2023-12-04T09:58:38.294Z,
    attemptedRemoteAddresses: [ '67.228.102.32:443', '2a03:2880:f112:83:face:b00c:0:25de:443' ],
    connectProtocol: 'https:',
    connectHost: 'discord.com',
    connectPort: ''
  },
  res: {
    status: -1,
    statusCode: -1,
    statusText: '',
    headers: {},
    size: 0,
    aborted: false,
    rt: 1511.335,
    keepAliveSocket: true,
    requestUrls: [ 'https://discord.com/api/v10/users/@me?index=0' ],
    timing: {
      queuing: 1.725,
      connected: 0,
      requestHeadersSent: 0,
      requestSent: 0,
      waiting: 0,
      contentDownload: 0
    },
    socket: {
      id: 1,
      localAddress: '',
      localPort: 0,
      remoteAddress: '',
      remotePort: 0,
      remoteFamily: '',
      bytesWritten: 0,
      bytesRead: 0,
      handledRequests: 0,
      handledResponses: 0,
      connectErrorTime: 2023-12-04T09:58:38.294Z,
      attemptedRemoteAddresses: [ '67.228.102.32:443', '2a03:2880:f112:83:face:b00c:0:25de:443' ],
      connectProtocol: 'https:',
      connectHost: 'discord.com',
      connectPort: ''
    },
    retries: 0,
    socketErrorRetries: 0
  },
  code: 'UND_ERR_CONNECT_TIMEOUT',
  opaque: undefined,
  [cause]: ConnectTimeoutError: Connect Timeout Error
      at onConnectTimeout (/Users/fengmk2/git/github.com/node-modules/urllib3/node_modules/.store/undici@5.28.2/node_modules/undici/lib/core/connect.js:186:24)
      at /Users/fengmk2/git/github.com/node-modules/urllib3/node_modules/.store/undici@5.28.2/node_modules/undici/lib/core/connect.js:133:46
      at Immediate._onImmediate (/Users/fengmk2/git/github.com/node-modules/urllib3/node_modules/.store/undici@5.28.2/node_modules/undici/lib/core/connect.js:174:9)
      at process.processImmediate (node:internal/timers:478:21) {
    code: 'UND_ERR_CONNECT_TIMEOUT'
  }
}
codecov[bot] commented 7 months ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (fde0d23) 99.65% compared to head (90ae964) 98.76%. Report is 1 commits behind head on master.

Files Patch % Lines
src/diagnosticsChannel.ts 87.50% 6 Missing :warning:
src/HttpClientError.ts 85.29% 5 Missing :warning:
src/HttpClient.ts 91.42% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #477 +/- ## ========================================== - Coverage 99.65% 98.76% -0.89% ========================================== Files 9 10 +1 Lines 1440 1542 +102 Branches 257 260 +3 ========================================== + Hits 1435 1523 +88 - Misses 5 19 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.