search

node-modules / urllib

Request HTTP(s) URLs in a complex world.
MIT License
726 stars 118 forks source link

feat: use undici v6 #514

Closed fengmk2 closed 3 months ago

fengmk2 commented 3 months ago

BREAKING CHANGE: drop Node.js < 18.19.0 support

part of https://github.com/eggjs/egg/issues/3644

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

[!WARNING]

Rate limit exceeded

@fengmk2 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 16 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between bfd7819fdcb355966d8fa704e635629946033f4e and 04c24de6f7f834eeff671489b3fccaab05b2ad64.

Walkthrough

The updates involve modernizing dependencies, refactoring modules, and enhancing configurations to support newer Node.js versions. Major changes include updating to Node.js versions 18, 20, and 22, refining import syntax, removing outdated patterns, and improving error handling. The documentation and configuration policies were also aligned to reflect these enhancements, ensuring higher compatibility and streamlined processes.

Changes

Files Change Summary
.eslintrc Removed parserOptions and ignorePatterns configurations
.github/workflows/nodejs.yml Updated Node.js versions to 18.19.0, 20, 22
README.md Replaced contributor list with dynamic badge and updated license section
package.json Updated version, dependencies, node engine requirement, scripts, and exports section
scripts/replace_urllib_version.js Updated replacement logic and imports
src/HttpClient.ts Refactored imports, removed unused functions, and updated HEADER_USER_AGENT
src/diagnosticsChannel.ts Simplified functions, updated type handling, and enhanced error handling
src/index.ts Changed import of LRU to a named import
src/utils.ts Explicitly typed JSONCtlCharsMap and removed sleep function from exports
test/diagnostics_channel.test.ts Updated import paths and added setTimeout from node:timers/promises
test/fixtures/server.ts Added import for setTimeout as sleep
test/keep-alive-header.test.ts Updated import statements and renamed sleep function
test/options.signal.test.ts Adjusted imports to use explicit .js extensions and added setTimeout as sleep
test/options.timeout.test.ts Simplified error handling logic
test/options.timing.test.ts Added setTimeout import and adjusted other imports
test/options.writeStream.test.ts Updated imports with .js extensions and added setTimeout as sleep
test/utils.ts Removed the sleep function and modified readableToBytes
tsconfig.json Changed noImplicitAny to true, removed several options, and retained module and moduleResolution settings

Poem

In code’s bright light, the changes gleam,
A clearer path, a modern dream,
With Node’s new strength and modules refined,
Compatibility we surely find.
Dependencies fresh, no patterns old,
Our project’s future now unfolds.
🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
socket-security[bot] commented 3 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/eslint-config-egg@13.1.0 Transitive: environment, eval, filesystem, shell, unsafe +244 36.4 MB fengmk2
npm/undici@6.19.2 environment, network 0 1.13 MB matteo.collina

🚮 Removed packages: npm/@types/default-user-agent@1.0.2, npm/@types/pump@1.1.3, npm/default-user-agent@1.0.0, npm/digest-header@1.1.0, npm/eslint-config-egg@12.3.1, npm/form-data-encoder@1.9.0, npm/formdata-node@4.4.1, npm/git-contributor@2.1.5, npm/pump@3.0.0, npm/undici@5.28.4

View full report↗︎

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.85%. Comparing base (d565da2) to head (04c24de). Report is 1 commits behind head on master.

Files Patch % Lines
src/diagnosticsChannel.ts 93.54% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #514 +/- ## ========================================== - Coverage 98.82% 97.85% -0.97% ========================================== Files 10 10 Lines 1618 1586 -32 Branches 274 255 -19 ========================================== - Hits 1599 1552 -47 - Misses 19 30 +11 - Partials 0 4 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.