search

node-modules / utility

A collection of useful utilities.
Other
1.24k stars 160 forks source link

feat: add replace invalid http header character #26

Closed leoner closed 7 years ago

mention-bot commented 7 years ago

@leoner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @dead-horse and @alsotang to be potential reviewers.

fengmk2 commented 7 years ago

benchmark 加上一个真实登录太的headers做测试吧

codecov[bot] commented 7 years ago

Codecov Report

Merging #26 into master will increase coverage by 0.05%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   98.97%   99.02%   +0.05%     
==========================================
  Files          12       12              
  Lines         292      307      +15     
==========================================
+ Hits          289      304      +15     
  Misses          3        3
Impacted Files Coverage Δ
lib/string.js 100% <100%> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e05ef3...c85ff0d. Read the comment docs.

codecov[bot] commented 7 years ago

Codecov Report

Merging #26 into master will increase coverage by 0.05%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   98.97%   99.02%   +0.05%     
==========================================
  Files          12       12              
  Lines         292      307      +15     
==========================================
+ Hits          289      304      +15     
  Misses          3        3
Impacted Files Coverage Δ
lib/string.js 100% <100%> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e05ef3...4a939fc. Read the comment docs.

fengmk2 commented 7 years ago

0.12 不支持 const https://travis-ci.org/node-modules/utility/jobs/201152011

alsotang commented 7 years ago

这么不通用的一个函数。。。怎么不新建一个包

leoner commented 7 years ago

改好了,去掉 const, 都改成 var了.

fengmk2 commented 7 years ago

@alsotang 太通用的，你要做 http proxy，都得使用这个函数

fengmk2 commented 7 years ago

@leoner 因为单测是 ava 跑的，它经过了 babel 编译。

leoner commented 7 years ago

好, 现在都过了.

fengmk2 commented 7 years ago

1.10.0